Modernize + Go version bump + Pin linter (#5256)

* Upgrade go version in CI.
* Add toolchain to pin version.
* Add linter/fumpt as pinned version in tools.
* Run `go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...`

Author: klauspost

.github/workflows/go-cross.yml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        go-version: [1.23.x]
+        go-version: [1.25.x]
         os: [ubuntu-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/go.yml

@@ -19,7 +19,7 @@ jobs:
       GO111MODULE: on
     strategy:
       matrix:
-        go-version: [1.23.x]
+        go-version: [1.25.x]
         os: [ubuntu-latest, macos-latest, windows-latest]
     steps:
       - name: Set up Go ${{ matrix.go-version }} on ${{ matrix.os }}
@@ -69,14 +69,11 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.23.x
+          go-version: 1.24.x
 
       - name: Checkout code
         uses: actions/checkout@v2
 
       - name: Test 386
         run: GOOS=linux GOARCH=386 go test -short ./...
 
-      - name: Staticcheck
-        # Run with defaults, but allow errors with other formats ST1005
-        run: go install honnef.co/go/tools/cmd/staticcheck@latest && make lint

.github/workflows/vulncheck.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.6
+          go-version: 1.25.x
       - name: Get official govulncheck
         run: go install golang.org/x/vuln/cmd/govulncheck@latest
         shell: bash

Makefile

@@ -8,8 +8,7 @@ TARGET_GOOS ?= $(shell go env GOOS)
 VERSION ?= $(shell git describe --tags)
 TAG ?= "minio/mc:$(VERSION)"
 
-GOLANGCI_DIR = .bin/golangci/$(GOLANGCI_VERSION)
-GOLANGCI = $(GOLANGCI_DIR)/golangci-lint
+GOLANGCI = $(GOPATH)/bin/golangci-lint
 
 all: build
 
@@ -19,8 +18,7 @@ checks:
 
 getdeps:
 	@mkdir -p ${GOPATH}/bin
-	@echo "Installing golangci-lint" && curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GOLANGCI_DIR)
-	@echo "Installing stringer" && go install -v golang.org/x/tools/cmd/stringer@latest
+	@echo "Installing tools" && go install tool
 
 crosscompile:
 	@(env bash $(PWD)/buildscripts/cross-compile.sh)

cmd/admin-bucket-remote-add_test.go

@@ -121,7 +121,6 @@ func TestGetBandwidthInBytes(t *testing.T) {
 	}
 	t.Parallel()
 	for _, tt := range tests {
-		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
 			if got, err := getBandwidthInBytes(tt.args.bandwidthStr); err != nil || got != tt.want {
 				t.Errorf("getBandwidthInBytes() = %v, want %v", got, tt.want)

cmd/admin-decom-status.go

@@ -125,7 +125,7 @@ func mainAdminDecommissionStatus(ctx *cli.Context) error {
 	}
 
 	dspOrder := []col{colGreen} // Header
-	for i := 0; i < len(poolStatuses); i++ {
+	for range poolStatuses {
 		dspOrder = append(dspOrder, colGrey)
 	}
 	var printColors []*color.Color

cmd/admin-replicate-resync-status.go

@@ -206,7 +206,7 @@ func (m *resyncMetricsUI) View() string {
 	table.SetNoWhiteSpace(true)
 
 	var data [][]string
-	addLine := func(prefix string, value interface{}) {
+	addLine := func(prefix string, value any) {
 		data = append(data, []string{
 			prefix,
 			whiteStyle.Render(fmt.Sprint(value)),

cmd/admin-replicate-status.go

@@ -426,10 +426,7 @@ func (i srStatus) String() string {
 				currDowntime = UTCNow().Sub(m.LastOnline)
 			}
 			// normalize because total downtime is calculated at server side at heartbeat interval, may be slightly behind
-			totalDowntime := m.TotalDowntime
-			if currDowntime > totalDowntime {
-				totalDowntime = currDowntime
-			}
+			totalDowntime := max(currDowntime, m.TotalDowntime)
 			var linkStatus string
 			if m.Online {
 				linkStatus = healthDot + fmt.Sprintf(" online (total downtime: %s)", timeDurationToHumanizedDuration(totalDowntime).String())

cmd/admin-scanner-status.go

@@ -397,7 +397,7 @@ func (m *scannerMetricsUI) View() string {
 		writtenRows++
 	}
 	_ = addRow
-	addRowF := func(format string, vals ...interface{}) {
+	addRowF := func(format string, vals ...any) {
 		s := fmt.Sprintf(format, vals...)
 		table.Append([]string{s})
 		writtenRows++
@@ -442,7 +442,7 @@ func (m *scannerMetricsUI) View() string {
 		if sc.CurrentCycle > 0 {
 			addRowF(title("Current cycle:")+"         %s; Started: %v", ui(sc.CurrentCycle), console.Colorize("metrics-date", sc.CurrentStarted))
 		} else {
-			addRowF(title("Current cycle:") + "         (between cycles)")
+			addRowF("%s", title("Current cycle:")+"         (between cycles)")
 		}
 	}
 

cmd/admin-service-restart.go

@@ -173,7 +173,7 @@ func (m *serviceRestartUI) View() string {
 
 func initServiceRestartUI(rowCount int, currentCh chan serviceRestartMessage) *serviceRestartUI {
 	var printColors []*color.Color
-	for i := 0; i < rowCount; i++ {
+	for range rowCount {
 		printColors = append(printColors, getPrintCol(colGreen))
 	}