fix: Improve popover render

Author: Victor Ohashi

lib/src/popover.dart

@@ -63,10 +63,6 @@ import 'utils/popover_utils.dart';
 ///
 /// The `onPop` called to veto attempts by the user to dismiss the popover.
 ///
-/// Pass `mounted` property from parent widget to the `isParentAlive`
-/// function to prevent red screen of death.
-/// `isParentAlive : () => mounted`
-///
 /// The `constraints` is popover's constraints.
 ///
 /// The `routeSettings` is data that might be useful in constructing a [Route].
@@ -96,7 +92,6 @@ Future<T?> showPopover<T extends Object?>({
   double? width,
   double? height,
   VoidCallback? onPop,
-  bool Function()? isParentAlive,
   BoxConstraints? constraints,
   RouteSettings? routeSettings,
   String? barrierLabel,
@@ -110,73 +105,48 @@ Future<T?> showPopover<T extends Object?>({
 
   return Navigator.of(context, rootNavigator: true).push<T>(
     RawDialogRoute<T>(
-      pageBuilder: (_, __, ___) {
-        return Builder(builder: (_) => const SizedBox.shrink());
+      pageBuilder: (_, animation, __) {
+        return WillPopScope(
+          onWillPop: () {
+            onPop?.call();
+            return Future.value(true);
+          },
+          child: PopoverItem(
+            transition: transition,
+            child: Builder(builder: bodyBuilder),
+            context: context,
+            backgroundColor: backgroundColor,
+            direction: direction,
+            radius: radius,
+            boxShadow: shadow,
+            animation: animation,
+            arrowWidth: arrowWidth,
+            arrowHeight: arrowHeight,
+            constraints: constraints,
+            arrowDxOffset: arrowDxOffset,
+            arrowDyOffset: arrowDyOffset,
+            contentDyOffset: contentDyOffset,
+            key: key,
+          ),
+        );
+      },
+      transitionBuilder: (builderContext, animation, _, child) {
+        return popoverTransitionBuilder == null
+            ? FadeTransition(
+                opacity: CurvedAnimation(
+                  parent: animation,
+                  curve: Curves.easeOut,
+                ),
+                child: child,
+              )
+            : popoverTransitionBuilder(animation, child);
       },
       barrierDismissible: barrierDismissible,
       barrierLabel: barrierLabel ??=
           MaterialLocalizations.of(context).modalBarrierDismissLabel,
       barrierColor: barrierColor,
       transitionDuration: transitionDuration,
       settings: routeSettings,
-      transitionBuilder: (builderContext, animation, _, child) {
-        return WillPopScope(
-          onWillPop: () {
-            if (onPop != null) {
-              onPop();
-              return Future.value(true);
-            } else {
-              return Future.value(true);
-            }
-          },
-          child: popoverTransitionBuilder == null
-              ? FadeTransition(
-                  opacity: CurvedAnimation(
-                    parent: animation,
-                    curve: Curves.easeOut,
-                  ),
-                  child: PopoverItem(
-                    transition: transition,
-                    child: bodyBuilder(builderContext),
-                    context: context,
-                    backgroundColor: backgroundColor,
-                    direction: direction,
-                    radius: radius,
-                    boxShadow: shadow,
-                    animation: animation,
-                    arrowWidth: arrowWidth,
-                    arrowHeight: arrowHeight,
-                    constraints: constraints,
-                    arrowDxOffset: arrowDxOffset,
-                    arrowDyOffset: arrowDyOffset,
-                    contentDyOffset: contentDyOffset,
-                    isParentAlive: isParentAlive,
-                    key: key,
-                  ),
-                )
-              : popoverTransitionBuilder(
-                  animation,
-                  PopoverItem(
-                    transition: transition,
-                    child: bodyBuilder(builderContext),
-                    context: context,
-                    backgroundColor: backgroundColor,
-                    direction: direction,
-                    radius: radius,
-                    boxShadow: shadow,
-                    animation: animation,
-                    arrowWidth: arrowWidth,
-                    arrowHeight: arrowHeight,
-                    constraints: constraints,
-                    arrowDxOffset: arrowDxOffset,
-                    arrowDyOffset: arrowDyOffset,
-                    contentDyOffset: contentDyOffset,
-                    isParentAlive: isParentAlive,
-                    key: key,
-                  ),
-                ),
-        );
-      },
     ),
   );
 }

lib/src/popover_item.dart

@@ -4,116 +4,55 @@ import '../popover.dart';
 import 'popover_context.dart';
 import 'popover_position_widget.dart';
 import 'utils/build_context_extension.dart';
-import 'utils/utils.dart';
 
 class PopoverItem extends StatefulWidget {
   final Widget child;
   final Color? backgroundColor;
   final PopoverDirection? direction;
   final double? radius;
   final List<BoxShadow>? boxShadow;
-  final Animation<double>? animation;
+  final Animation<double> animation;
   final double? arrowWidth;
-  final double? arrowHeight;
+  final double arrowHeight;
   final BoxConstraints? constraints;
   final BuildContext context;
-  final double? arrowDxOffset;
-  final double? arrowDyOffset;
-  final double? contentDyOffset;
-  final bool Function()? isParentAlive;
+  final double arrowDxOffset;
+  final double arrowDyOffset;
+  final double contentDyOffset;
   final PopoverTransition transition;
 
   const PopoverItem({
     required this.child,
     required this.context,
     required this.transition,
+    required this.animation,
+    required this.arrowHeight,
     this.backgroundColor,
     this.direction,
     this.radius,
     this.boxShadow,
-    this.animation,
     this.arrowWidth,
-    this.arrowHeight,
     this.constraints,
-    this.arrowDxOffset,
-    this.arrowDyOffset,
-    this.contentDyOffset,
-    this.isParentAlive,
-    Key? key,
-  }) : super(key: key);
+    this.arrowDxOffset = 0,
+    this.arrowDyOffset = 0,
+    this.contentDyOffset = 0,
+    super.key,
+  });
 
   @override
   _PopoverItemState createState() => _PopoverItemState();
 }
 
 class _PopoverItemState extends State<PopoverItem> {
-  late BoxConstraints constraints;
-  late Offset offset;
-  late Rect bounds;
-  late Rect attachRect;
-
-  @override
-  Widget build(BuildContext context) {
-    return LayoutBuilder(
-      builder: (_, __) {
-        _configure();
-        return Stack(
-          children: [
-            PopoverPositionWidget(
-              attachRect: attachRect,
-              scale: widget.animation,
-              constraints: constraints,
-              direction: widget.direction,
-              arrowHeight: widget.arrowHeight,
-              child: PopoverContext(
-                attachRect: attachRect,
-                animation: widget.animation,
-                radius: widget.radius,
-                backgroundColor: widget.backgroundColor,
-                boxShadow: widget.boxShadow,
-                direction: widget.direction,
-                arrowWidth: widget.arrowWidth,
-                arrowHeight: widget.arrowHeight,
-                transition: widget.transition,
-                child: Material(
-                  type: MaterialType.transparency,
-                  child: widget.child,
-                ),
-              ),
-            )
-          ],
-        );
-      },
-    );
-  }
-
-  void _configure() {
-    final bool isParentAlive;
-
-    if (widget.isParentAlive != null) {
-      isParentAlive = widget.isParentAlive!();
-    } else {
-      isParentAlive = true;
-    }
-
-    if (!isParentAlive) {
-      return;
-    }
-
-    final box = widget.context.findRenderObject() as RenderBox;
-    if (mounted && box.owner != null) {
-      _configureConstraints();
-      _configureRect();
-    }
-  }
+  late Rect _attachRect;
+  BoxConstraints? _constraints;
 
   void _configureConstraints() {
-    BoxConstraints _constraints;
+    final size = MediaQuery.of(context).size;
+    var constraints = BoxConstraints.loose(size);
+
     if (widget.constraints != null) {
-      _constraints = BoxConstraints(
-        maxHeight: Utils().screenHeight / 2,
-        maxWidth: Utils().screenHeight / 2,
-      ).copyWith(
+      constraints = constraints.copyWith(
         minWidth: widget.constraints!.minWidth.isFinite
             ? widget.constraints!.minWidth
             : null,
@@ -127,34 +66,81 @@ class _PopoverItemState extends State<PopoverItem> {
             ? widget.constraints!.maxHeight
             : null,
       );
-    } else {
-      _constraints = BoxConstraints(
-        maxHeight: Utils().screenHeight / 2,
-        maxWidth: Utils().screenHeight / 2,
-      );
     }
+
     if (widget.direction == PopoverDirection.top ||
         widget.direction == PopoverDirection.bottom) {
-      constraints = _constraints.copyWith(
-        maxHeight: _constraints.maxHeight + widget.arrowHeight!,
-        maxWidth: _constraints.maxWidth,
-      );
+      final maxHeight = constraints.maxHeight + widget.arrowHeight;
+      constraints = constraints.copyWith(maxHeight: maxHeight);
     } else {
-      constraints = _constraints.copyWith(
-        maxHeight: _constraints.maxHeight + widget.arrowHeight!,
-        maxWidth: _constraints.maxWidth + widget.arrowWidth!,
+      constraints = constraints.copyWith(
+        maxHeight: constraints.maxHeight + widget.arrowHeight,
+        maxWidth: constraints.maxWidth + widget.arrowWidth!,
       );
     }
+
+    _constraints = constraints;
   }
 
   void _configureRect() {
-    offset = BuildContextExtension.getWidgetLocalToGlobal(widget.context);
-    bounds = BuildContextExtension.getWidgetBounds(widget.context);
-    attachRect = Rect.fromLTWH(
-      offset.dx + (widget.arrowDxOffset ?? 0.0),
-      offset.dy + (widget.arrowDyOffset ?? 0.0),
-      bounds.width,
-      bounds.height + (widget.contentDyOffset ?? 0.0),
+    final offset = BuildContextExtension.getWidgetLocalToGlobal(widget.context);
+    final bounds = BuildContextExtension.getWidgetBounds(widget.context);
+
+    if (offset != null && bounds != null) {
+      _attachRect = Rect.fromLTWH(
+        offset.dx + (widget.arrowDxOffset),
+        offset.dy + (widget.arrowDyOffset),
+        bounds.width,
+        bounds.height + (widget.contentDyOffset),
+      );
+    }
+  }
+
+  @override
+  void initState() {
+    _configureRect();
+    super.initState();
+  }
+
+  @override
+  void didChangeDependencies() {
+    _configureConstraints();
+    WidgetsBinding.instance.addPostFrameCallback(
+      (_) => setState(_configureRect),
+    );
+
+    super.didChangeDependencies();
+  }
+
+  @override
+  Widget build(BuildContext context) {
+    return Stack(
+      children: [
+        PopoverPositionWidget(
+          attachRect: _attachRect,
+          constraints: _constraints,
+          direction: widget.direction,
+          arrowHeight: widget.arrowHeight,
+          child: AnimatedBuilder(
+            animation: widget.animation,
+            builder: (context, child) {
+              return PopoverContext(
+                attachRect: _attachRect,
+                animation: widget.animation,
+                radius: widget.radius,
+                backgroundColor: widget.backgroundColor,
+                boxShadow: widget.boxShadow,
+                direction: widget.direction,
+                arrowWidth: widget.arrowWidth,
+                arrowHeight: widget.arrowHeight,
+                transition: widget.transition,
+                child: child,
+              );
+            },
+            child: Material(child: widget.child),
+          ),
+        )
+      ],
     );
   }
 }