Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy when sharing entries #3093

Open
eyJhb opened this issue Jan 20, 2025 · 2 comments
Open

Add support for proxy when sharing entries #3093

eyJhb opened this issue Jan 20, 2025 · 2 comments
Labels

Comments

@eyJhb
Copy link

eyJhb commented Jan 20, 2025

When having set up proxying for e.g. images, this works fine when initially viewing a article. However, as soon as the article is shared, the proxy is bypassed and no longer used.

This doesn't seem intended, at least not obvious when initially setting the proxy.

I couldn't find other issues related to this, so hopefully I didn't miss anything :)

@fguillot
Copy link
Member

This is currently the expected behavior. The media proxy is not used in the public/non-authenticated views. It has been implemented this way since the sharing feature exists (see #475). However, that could be changed, or become configurable.

{{ if .user }}
{{ noescape (proxyFilter .entry.Content) }}
{{ else }}
{{ noescape .entry.Content }}
{{ end }}

@eyJhb
Copy link
Author

eyJhb commented Jan 27, 2025

I think it would be fairly nice to support that. I try to host privacy centered services, and I had somewhat expected this to be the functionality.

Could this get a feature request tag instead? And a renamed title?

@eyJhb eyJhb changed the title Proxy not respected when sharing article Add support for proxy when sharing entries Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants