-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of string issues #539
Comments
I've fixed all the non-tag issues, I delegate the management of tags to others
There are now gettext contexts for |
I just went ahead and edited the tag descriptions myself in the tag editor. Now all strings should be fixed but Weblate needs another update for the tags. OK, there is one exception. Maybe.
This string appears when I favourite something. Weblate still forces a HTML escape code for ">" in my translation. Any idea how to fix it? |
I agree on most other stuff, but I'll comment on the GUI tag, since I'm the one that originally added that tag
While it's true that it is technical, the suggested change doesn't reflect the actual use case of the To build up on your suggestion, I suggest: |
For reference what rubenwardy meant by "I delegate the management of tags to others" is that @Lemente (and sometimes me) are the one who takes care of it |
Feel free to edit the GUI description further. My only issue is the word "formspec" being too technical since players might not know what that is. "formspec" is a Minetest-only term. |
Looks like this is the only remaining issue here. Any idea what I need to do to tell weblate whether a string is html or plaintext? |
I dug through the documentation and I think I found the problem! The string has the flag "safe-html" set in Weblate. safe-html checks for "unsafe" HTML characters in the string. And apparently, safe-html comes with an autofixer. Obviously, we don't want this here. https://docs.weblate.org/de/weblate-5.5.5/user/checks.html#check-safe-html Note this can only be fixed in Weblate since this is Weblate behavior. It has nothing to do with the ContentDB itself. To fix this, replace the flags with "ignore-safe-html". You can do this by navigating to the offending string in Weblate and then click the little edit button at the flags to the right. |
So my preference would be to use two different The Customizing behavior using flags section implies you can set flags from a translation file but the "Supported file formats" page doesn't say how to do it for Gettext:
|
You can change it directly in the Weblate interface. But if you want to do this directly in the PO file, I don't know what to do. Maybe ask #weblate on libera.chat IRC? |
Summary
After translating ContentDB strings again, I ran into a couple of low-quality strings so I suggest to fix/improve them.
Strings with syntax/grammar/spelling mistakes
[FIXED!] This string contains literal "greater than" signs inside HTML. This is a syntax error. Replace with the HTML escape code.
Not a problem with the string itself, but when I put the ">" sign in the translation in Weblate, it turns it into a HTML escape code, which then shows up literally when this message appears in ContentDB. I believe this needs to be fixed in Weblate settings or something, idk.
[FIXED!] Replace "TheSims" with "The Sims" (official name). Replace "etc" with "etc.".
[FIXED!] Replace "luarocks" with "LuaRocks" (official name).
[FIXED!] Poor/weird grammar. Suggestion: "Focus on player chat/communication or the primary function is console interaction."
[FIXED!] Poor grammar. Suggestion: Remove the first "what".
Duplicate strings
[FIXED!] This string is used twice with two completely different contexts. The first context is for a tag for item storage like chests. The second context is storage of data. In German, it must be translated with 2 different words (there is no workaround, sorry).
Please use a gettext context or change one of the strings to fix the ambiguity.
Strings of low quality (debatable)
[FIXED!] Too technical. Avoid the term "formspec". I suggest: "For content whose main utility about providing or improving the GUI, on-screen menus and the like"
[FIXED!] Replace "NPCs" with "non-player characters". Because this is the long description of a tag.
[FIXED!] This is a long tag description, so write it in full: "Forks of Minetest Game"
The text was updated successfully, but these errors were encountered: