Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect markdown rendering of code block in list item #409

Closed
fgaz opened this issue Dec 20, 2022 · 3 comments
Closed

Incorrect markdown rendering of code block in list item #409

fgaz opened this issue Dec 20, 2022 · 3 comments

Comments

@fgaz
Copy link

fgaz commented Dec 20, 2022

Summary

In a mod's readme, this code

* item
  ```
  line 1
  line 2
  ```

results in inline code like this:

  • item line 1 line 2

instead of

  • item
    line 1
    line 2
    
Steps to reproduce

Encountered here (Settings section). Correct rendering here

edit: I changed the markdown in contentdb to have a better rendering, but the upstream markdown still triggers the bug

@rubenwardy rubenwardy closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2023
@rubenwardy rubenwardy reopened this May 19, 2023
@rubenwardy
Copy link
Member

There is supposed to be a blank line between the text and the code block, but ContentDB also doesn't support that

@rubenwardy rubenwardy closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@fgaz
Copy link
Author

fgaz commented Jun 7, 2024

I suppose this was closed because it's an upstream issue. Do you know if there is a ticket about it in the upstream tracker?

@rubenwardy
Copy link
Member

rubenwardy commented Jun 7, 2024

This is intended behaviour by the python markdown parser as markdown requires blank lines between blocks

I'm planning on moving away from python markdown to something a bit less strict, see #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants