Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent chat message when shops without items found #11

Open
S-S-X opened this issue Dec 20, 2020 · 0 comments
Open

Inconsistent chat message when shops without items found #11

S-S-X opened this issue Dec 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@S-S-X
Copy link
Contributor

S-S-X commented Dec 20, 2020

if data and #data > 0 then
minetest.chat_send_player(playername, "Got " .. #data .. " results")
show_formspec(playername, data)

[13:59.51] <pandorabot> <Yang> why does the /search give more results than it shows? i was searching for a shop and it gave me 5 results but showed 3
[14:01.11] <pandorabot> <SX> sounds like a bug in mod
[14:03.41] <pandorabot> <OgelGames@Discord> doesnt show out of stock shops, but must still count them...
[14:04.08] <pandorabot> <Yang> stock shops?
[14:04.20] <pandorabot> <SolDeNoche> shops that are sold o
[14:04.32] <pandorabot> <Yang> oh
[14:07.16] <pandorabot> <SX> chat message could be moved to show_formspec to easily fix result counts and also possibly show how many out of stock shops
were found
[14:08.50] <pandorabot> <SX> or even add separate filtering function before show_formspec, could be better
@BuckarooBanzay BuckarooBanzay added the bug Something isn't working label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants