Skip to content

Commit 599d479

Browse files
committed
Merge pull request #1 from mindsnacks/fix/tracking-release-reset
[FINAL] Don't reset values on upgrade.
2 parents afa168a + dd47b73 commit 599d479

File tree

1 file changed

+39
-54
lines changed

1 file changed

+39
-54
lines changed

Appirater.m

+39-54
Original file line numberDiff line numberDiff line change
@@ -337,40 +337,32 @@ - (void)incrementUseCount {
337337
{
338338
trackingVersion = version;
339339
[userDefaults setObject:version forKey:kAppiraterCurrentVersion];
340-
}
341-
342-
if (_debug)
343-
NSLog(@"APPIRATER Tracking version: %@", trackingVersion);
344-
345-
if ([trackingVersion isEqualToString:version])
346-
{
347-
// check if the first use date has been set. if not, set it.
348-
NSTimeInterval timeInterval = [userDefaults doubleForKey:kAppiraterFirstUseDate];
349-
if (timeInterval == 0)
350-
{
351-
timeInterval = [[NSDate date] timeIntervalSince1970];
352-
[userDefaults setDouble:timeInterval forKey:kAppiraterFirstUseDate];
353-
}
354-
355-
// increment the use count
356-
NSInteger useCount = [userDefaults integerForKey:kAppiraterUseCount];
357-
useCount++;
358-
[userDefaults setInteger:useCount forKey:kAppiraterUseCount];
359-
if (_debug)
360-
NSLog(@"APPIRATER Use count: %@", @(useCount));
361-
}
362-
else
363-
{
364-
// it's a new version of the app, so restart tracking
365-
[userDefaults setObject:version forKey:kAppiraterCurrentVersion];
366340
[userDefaults setDouble:[[NSDate date] timeIntervalSince1970] forKey:kAppiraterFirstUseDate];
367-
[userDefaults setInteger:1 forKey:kAppiraterUseCount];
341+
[userDefaults setInteger:0 forKey:kAppiraterUseCount];
368342
[userDefaults setInteger:0 forKey:kAppiraterSignificantEventCount];
369343
[userDefaults setBool:NO forKey:kAppiraterRated];
370344
[userDefaults setBool:NO forKey:kAppiraterDeclinedToRate];
371345
[userDefaults setDouble:0 forKey:kAppiraterReminderRequestDate];
372346
}
373347

348+
if (_debug)
349+
NSLog(@"APPIRATER Tracking version: %@", trackingVersion);
350+
351+
// check if the first use date has been set. if not, set it.
352+
NSTimeInterval timeInterval = [userDefaults doubleForKey:kAppiraterFirstUseDate];
353+
if (timeInterval == 0)
354+
{
355+
timeInterval = [[NSDate date] timeIntervalSince1970];
356+
[userDefaults setDouble:timeInterval forKey:kAppiraterFirstUseDate];
357+
}
358+
359+
// increment the use count
360+
NSInteger useCount = [userDefaults integerForKey:kAppiraterUseCount];
361+
useCount++;
362+
[userDefaults setInteger:useCount forKey:kAppiraterUseCount];
363+
if (_debug)
364+
NSLog(@"APPIRATER Use count: %@", @(useCount));
365+
374366
[userDefaults synchronize];
375367
}
376368

@@ -385,40 +377,33 @@ - (void)incrementSignificantEventCount {
385377
{
386378
trackingVersion = version;
387379
[userDefaults setObject:version forKey:kAppiraterCurrentVersion];
388-
}
389-
390-
if (_debug)
391-
NSLog(@"APPIRATER Tracking version: %@", trackingVersion);
392-
393-
if ([trackingVersion isEqualToString:version])
394-
{
395-
// check if the first use date has been set. if not, set it.
396-
NSTimeInterval timeInterval = [userDefaults doubleForKey:kAppiraterFirstUseDate];
397-
if (timeInterval == 0)
398-
{
399-
timeInterval = [[NSDate date] timeIntervalSince1970];
400-
[userDefaults setDouble:timeInterval forKey:kAppiraterFirstUseDate];
401-
}
402-
403-
// increment the significant event count
404-
NSInteger sigEventCount = [userDefaults integerForKey:kAppiraterSignificantEventCount];
405-
sigEventCount++;
406-
[userDefaults setInteger:sigEventCount forKey:kAppiraterSignificantEventCount];
407-
if (_debug)
408-
NSLog(@"APPIRATER Significant event count: %@", @(sigEventCount));
409-
}
410-
else
411-
{
412-
// it's a new version of the app, so restart tracking
413-
[userDefaults setObject:version forKey:kAppiraterCurrentVersion];
414380
[userDefaults setDouble:0 forKey:kAppiraterFirstUseDate];
415381
[userDefaults setInteger:0 forKey:kAppiraterUseCount];
416-
[userDefaults setInteger:1 forKey:kAppiraterSignificantEventCount];
382+
[userDefaults setInteger:0 forKey:kAppiraterSignificantEventCount];
417383
[userDefaults setBool:NO forKey:kAppiraterRated];
418384
[userDefaults setBool:NO forKey:kAppiraterDeclinedToRate];
419385
[userDefaults setDouble:0 forKey:kAppiraterReminderRequestDate];
420386
}
421387

388+
if (_debug)
389+
NSLog(@"APPIRATER Tracking version: %@", trackingVersion);
390+
391+
// check if the first use date has been set. if not, set it.
392+
NSTimeInterval timeInterval = [userDefaults doubleForKey:kAppiraterFirstUseDate];
393+
if (timeInterval == 0)
394+
{
395+
timeInterval = [[NSDate date] timeIntervalSince1970];
396+
[userDefaults setDouble:timeInterval forKey:kAppiraterFirstUseDate];
397+
}
398+
399+
// increment the significant event count
400+
NSInteger sigEventCount = [userDefaults integerForKey:kAppiraterSignificantEventCount];
401+
sigEventCount++;
402+
[userDefaults setInteger:sigEventCount forKey:kAppiraterSignificantEventCount];
403+
404+
if (_debug)
405+
NSLog(@"APPIRATER Significant event count: %@", @(sigEventCount));
406+
422407
[userDefaults synchronize];
423408
}
424409

0 commit comments

Comments
 (0)