Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of private_constant breaks Ruby 1.9.2 #77

Closed
krisleech opened this issue Oct 20, 2014 · 7 comments
Closed

Use of private_constant breaks Ruby 1.9.2 #77

krisleech opened this issue Oct 20, 2014 · 7 comments
Assignees
Labels
Milestone

Comments

@krisleech
Copy link

https://github.com/halostatue/mime-types/blob/master/lib/mime/type.rb#L77
https://github.com/halostatue/mime-types/blob/master/lib/mime/types/loader.rb#L238

This is in v2.4.2

I think this breakage may be intentional since 1.9.2 is not in .travis.yml?

@halostatue
Copy link
Member

It isn’t intended. I’ll fix it in a patch. (I try to keep compatibility with 1.9.2, but do not run tests for it because of problems I had with Travis and 1.9.2.)

@halostatue halostatue added the Bug label Oct 21, 2014
@halostatue halostatue added this to the 2.4 milestone Oct 21, 2014
@halostatue halostatue self-assigned this Oct 21, 2014
@krisleech
Copy link
Author

Excellent, thanks!

@halostatue
Copy link
Member

I don’t have 1.9.2 handy—can you test whether the current version on master works?

@krisleech
Copy link
Author

master on 1.9.2, all tests pass 💚

@halostatue
Copy link
Member

Thank you. Releasing now.

@halostatue
Copy link
Member

Released, and 2.4.2 has been yanked.

@krisleech
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants