Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking issue - enable rangeproof verifier cache #3606

Closed
antiochp opened this issue Mar 19, 2021 · 1 comment
Closed

tracking issue - enable rangeproof verifier cache #3606

antiochp opened this issue Mar 19, 2021 · 1 comment

Comments

@antiochp
Copy link
Member

I think we want to do the following initially -

  • fix the cache key impl for rangeproofs
    • @jaspervdm suggested implementing DefaultHashable for the full output (identifier + rangeproof)
  • revert Removing verifier caches #3597 ensuring we use the correct cache key impl

Additional possible improvements -

We get most of the benefit from the verifier cache internally in the mempool. We do a lot of tx verification in various mempool operations. For example after aggregating txs together we verify the aggregated tx. Each verification leverages the rangeproof verifier cache as we do not want to verify the rangeproofs repeatedly each time.

But we may want to consider disabling the cache when we actually verify a new block.
Blocks are consensus critical, transactions are not.
We would need to take care to handle edge cases where a potentially invalid tx entered the mempool.
This makes me hesitate a little.

@antiochp
Copy link
Member Author

antiochp commented Apr 1, 2021

After some investigation and discussion we are removing the "verifier cache" entirely (for now) -
#3628

Future work may involve reintroducing some form of cache.

@antiochp antiochp closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant