Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file - inconsistent behavior with missing values #3002

Open
josef-v opened this issue Aug 26, 2019 · 1 comment
Open

Config file - inconsistent behavior with missing values #3002

josef-v opened this issue Aug 26, 2019 · 1 comment

Comments

@josef-v
Copy link

josef-v commented Aug 26, 2019

I was trying to minimize my config file, as I usually only keep key-value pairs that are necessary (e. g. in config files of other coin daemons). I am used to believe that missing keys in config files fallback to default values. I would also expect that the default config file contains the default values.
I have following issues with grin behavior:

  • Some options can't be removed from config file at all or the app crashes at start. I would be willing to accept this behavior with options that are security related, but log_to_file? C'mon!
  • I can't be sure about the default values. I couldn't find any reference which states, that values in config file are the default ones. Well, obviously, because it is not true. You enable/disable API authentication by commenting api_secret_path! It would be nice to have documented default values in the config file (or at least somewhere).

Of course this is not a big issue, but I believe I am not the only one who likes to glance at the config file and see where I have chosen to use non-default values and also have a compact config. Also, the described behavior is unpredictable, which is probably never a good thing. (Do I use the defaults by commenting this out? What is the default, is it this value?)

For context, here is link to my whine on grin forum.

@reagentoo
Copy link

reagentoo commented Jul 15, 2020

Config options api_secret_path and foreign_api_secret_path don't work. This files are saving to ~/.grin/main anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants