Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link to "transaction UML" in the docs' TOC is broken #2792

Closed
fresheneesz opened this issue May 2, 2019 · 3 comments
Closed

The link to "transaction UML" in the docs' TOC is broken #2792

fresheneesz opened this issue May 2, 2019 · 3 comments

Comments

@fresheneesz
Copy link
Contributor

Describe the bug
In the table of contents, the link to "transaction UML" is broken. I also don't see anywhere that clearly explains the protocol for a mimblewimble transaction (specifically what steps there are in the back-and-forth, and what data is sent in those steps). I assumed that's what the link to "transaction UML" was for.

@lehnberg lehnberg added the task label May 2, 2019
@lehnberg
Copy link
Collaborator

lehnberg commented May 2, 2019

Thank you for raising an issue about this! This is probably due to a move of wallet into it's own repo, /grin-wallet. The correct link to the transaction UML is here: https://github.com/mimblewimble/grin-wallet/blob/master/doc/transaction/basic-transaction-wf.png

Would you mind raising a PR to fix this?

@fresheneesz
Copy link
Contributor Author

Alright, created a PR: #2798

@lehnberg
Copy link
Collaborator

lehnberg commented May 2, 2019

Awesome - looks it's merged already! Closing this one now, thanks for your help @fresheneesz!

@lehnberg lehnberg closed this as completed May 2, 2019
@lehnberg lehnberg added the fixed label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants