Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't cancel a received tx with the same Id twice #2514

Closed
Onefox opened this issue Feb 1, 2019 · 3 comments
Closed

Can't cancel a received tx with the same Id twice #2514

Onefox opened this issue Feb 1, 2019 · 3 comments

Comments

@Onefox
Copy link
Contributor

Onefox commented Feb 1, 2019

Describe the bug
If I receive a tx with ID 32222222-3222-4222-a222-322222222222 for example. Than I cancel that via http://127.0.0.1:13420/v1/wallet/owner/cancel_tx?tx_id=32222222-3222-4222-a222-322222222222

Now I receive another tx with that ID.
I can't cancel the new one. When calling
http://127.0.0.1:13420/v1/wallet/owner/cancel_tx?tx_id=32222222-3222-4222-a222-322222222222
I am getting
Transaction 32222222-3222-4222-a222-322222222222 doesn't exist

Steps to reproduce the behavior:

  1. Receive grin with ID 32222222-3222-4222-a222-322222222222
  2. Cancel that receive via http://127.0.0.1:13420/v1/wallet/owner/cancel_tx?tx_id=32222222-3222-4222-a222-322222222222
  3. Receive the same tx again (for example with the listen api)
  4. Try to Cancel that ID again...
  5. See error Transaction 32222222-3222-4222-a222-322222222222 doesn't exist

Here is my txs wallet output:
image

master tag V1.0.0

@mcdallas
Copy link
Contributor

mcdallas commented Feb 1, 2019

UUIDs are meant to be unique (universally unique identifier)

@Onefox
Copy link
Contributor Author

Onefox commented Feb 1, 2019

Thats true, still the error message is not great and I don't see any problem why this should not work.

@quentinlesceller
Copy link
Member

Indeed I think this is something we did not think of at when we implemented the cancel by tx_id function. Opened mimblewimble/grin-wallet#27 in grin-wallet repo to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants