Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxHashSet download speed not accurate #2488

Closed
DavidBurkett opened this issue Jan 29, 2019 · 3 comments
Closed

TxHashSet download speed not accurate #2488

DavidBurkett opened this issue Jan 29, 2019 · 3 comments

Comments

@DavidBurkett
Copy link
Contributor

My node was trying to sync the state with a peer that was uploading at 600 kB/s and got to 98% and then the peer stopped uploading (haven't investigated that yet). What I noticed though is that rather than download speed updating to 0 kB/s, it must be using the average over the entire timeframe, so the download speed slowly peters out (trust me, this is the technical term). Still, 5-10 minutes after the peer stopped uploading data, my node still says it's downloading at 200 kB/s.

Calculating this correctly could be a bit tricky, but even if we go with a less sophisticated approach, like updating every 5-10 seconds, it'd still be a whole lot better than what we do today.

@DavidBurkett DavidBurkett changed the title TxHashSet download speed not accurate- TxHashSet download speed not accurate Jan 29, 2019
@c410-f3r
Copy link

cc #2633

I think this issue can be closed now.

@DavidBurkett
Copy link
Contributor Author

DavidBurkett commented May 20, 2019

I just experienced this exact same issue 2 days ago. I think it still needs some more work. If nobody else has experienced the problem though, I'm fine with closing it.

@yeastplume
Copy link
Member

Just going to close this for sake of housekeeping, if you still think it needs work by all means reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants