Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner_api_listen_port missing field in grin-wallet.toml #2482

Closed
antiochp opened this issue Jan 28, 2019 · 3 comments
Closed

owner_api_listen_port missing field in grin-wallet.toml #2482

antiochp opened this issue Jan 28, 2019 · 3 comments
Labels
bug help wanted must-have Required for the associated milestone
Milestone

Comments

@antiochp
Copy link
Member

Related #2475.

A new config item was added in #2475 -

owner_api_listen_port

We need to be able to safely handle the case where this is missing (i.e. all existing wallets).

Otherwise the wallet fails to startup successfully with a missing field error.

@antiochp antiochp added bug help wanted must-have Required for the associated milestone labels Jan 28, 2019
@antiochp antiochp added this to the 1.0.1 milestone Jan 28, 2019
@antiochp
Copy link
Member Author

Not sure if the solution here is to recreate the config file (and fill in any missing values), or to safely handle this value as optional.

@yeastplume What's the recommended fix here? I know you've worked on some reading/rewriting config files stuff.

@antiochp
Copy link
Member Author

antiochp commented Jan 28, 2019

Note: workaround is to add it manually to grin-wallet.toml -

owner_api_listen_port = 3420

@yeastplume
Copy link
Member

for backwards compat it needs to be an Option in the internal struct, then have something set it to the default value if it’s missing when read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted must-have Required for the associated milestone
Projects
None yet
Development

No branches or pull requests

2 participants