Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the potential issue of a smaller LMDB? #2370

Closed
azilber opened this issue Jan 14, 2019 · 4 comments
Closed

What is the potential issue of a smaller LMDB? #2370

azilber opened this issue Jan 14, 2019 · 4 comments
Labels

Comments

@azilber
Copy link

azilber commented Jan 14, 2019

Compiling on a 32bit ARM platform yields:

`error: literal out of range for usize
--> store/src/lmdb.rs:76:16
|
76 | .set_mapsize(549_755_813_888)
| ^^^^^^^^^^^^^^^
|
= note: #[deny(overflowing_literals)] on by default

error: aborting due to previous error

error: Could not compile grin_store.
`

I know 32bit is not supported... BUT, if lower env_builder.set_mapsize to 4_294_967_000 I can get it to build. What (and when) is the potential fubar moment expected? 😀

@ignopeverell
Copy link
Contributor

A larger size is mostly future proofing. On 32 bits you limit your state storage to 2^32 bytes, which isn't that large for storage. That being said we're still very far from that, so you can start that way and monitor the size regularly.

@sesam
Copy link
Contributor

sesam commented Jan 15, 2019 via email

@0xmichalis
Copy link
Contributor

can we have grin autodetect or keep a smaller value for limited archs? Maybe a build time flag or crate feature to get default grin building on more systems. And add to the build/contrib guide whats needed for some archs.

See also #1681

@yeastplume
Copy link
Member

Think this is answered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants