-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet seed recovery process leaves recovery phrase in shell history #2174
Comments
Smth like pinentry https://www.gnupg.org/related_software/pinentry/index.html |
Or, maybe easier, use |
Tried the stdin approach.. it's pants. Make one mistake and you have to enter everything again, backspace doesn't work, you can't populate it with the previous attempt to let the user fix errors. We could go something like: Then give a menu for editing your word list... might work but also sounds pants from a UI perspective. |
Silly idea perhaps, but since we're discussing pants in any case: is it not possible to wipe bash history as part of carrying out a restore from seed command? https://unix.stackexchange.com/questions/203290/how-do-i-clear-the-terminal-history |
Unfortunately, I don't think wiping your bash history is something a well-behaved member of the executable community should be doing. |
Fixed by #2201 |
The current wallet seed recovery process involves typing or pasting the recovery phrase on the command line, which leaves it lying around in the shell history. We need a better way of doing this to ensure it's not stored, in a manner that balances a bit of usability with the inevitable challenges in doing it all through a command line.
The text was updated successfully, but these errors were encountered: