Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet seed recovery process leaves recovery phrase in shell history #2174

Closed
yeastplume opened this issue Dec 18, 2018 · 7 comments
Closed
Labels
good first issue help wanted must-have Required for the associated milestone
Milestone

Comments

@yeastplume
Copy link
Member

The current wallet seed recovery process involves typing or pasting the recovery phrase on the command line, which leaves it lying around in the shell history. We need a better way of doing this to ensure it's not stored, in a manner that balances a bit of usability with the inevitable challenges in doing it all through a command line.

@yeastplume yeastplume added help wanted good first issue must-have Required for the associated milestone labels Dec 18, 2018
@yeastplume yeastplume added this to the Mainnet milestone Dec 18, 2018
@hashmap
Copy link
Contributor

hashmap commented Dec 18, 2018

@jaspervdm
Copy link
Contributor

Or, maybe easier, use std::io::stdin?

@mrpqzm
Copy link

mrpqzm commented Dec 21, 2018

@yeastplume
Copy link
Member Author

Tried the stdin approach.. it's pants. Make one mistake and you have to enter everything again, backspace doesn't work, you can't populate it with the previous attempt to let the user fix errors.

We could go something like:
Enter word 1) this
enter word 2) is

Then give a menu for editing your word list... might work but also sounds pants from a UI perspective.

@lehnberg
Copy link
Collaborator

Silly idea perhaps, but since we're discussing pants in any case: is it not possible to wipe bash history as part of carrying out a restore from seed command?

https://unix.stackexchange.com/questions/203290/how-do-i-clear-the-terminal-history

@yeastplume
Copy link
Member Author

Unfortunately, I don't think wiping your bash history is something a well-behaved member of the executable community should be doing.

@ignopeverell
Copy link
Contributor

Fixed by #2201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted must-have Required for the associated milestone
Projects
None yet
Development

No branches or pull requests

6 participants