Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration option to auto-start wallet listener #2064

Closed
hashmap opened this issue Dec 2, 2018 · 4 comments
Closed

Configuration option to auto-start wallet listener #2064

hashmap opened this issue Dec 2, 2018 · 4 comments

Comments

@hashmap
Copy link
Contributor

hashmap commented Dec 2, 2018

Currently user has to run grin wallet listen manually. Would be nice to have a config option on grin-server.toml to auto start it (as it used to be). In this case impl of #2063 could use it to provide a better user experience and reduce number if question in the gitter channel.

@Onefox
Copy link
Contributor

Onefox commented Dec 3, 2018

On what account would the listen work, the Default?

Also this would mix wallet and server again or?
The server/node also has to have an open wallet attach.

@yeastplume
Copy link
Member

We explicitly removed this and I think it should stay removed. Users should explicitly be creating and managing their wallets, which means initialising the wallet themselves, writing down their recovery phrases, and creating/using a password. If we had a config option to start this, we'd need somewhere for a user to store a password, or default to a blank password (which I don't think we want to do for mainnet.

I agree the user experience needs to be better, but I don't think this is the solution.

@hashmap
Copy link
Contributor Author

hashmap commented Dec 3, 2018

@Onefox yes, if user needs more sophisticated setup we assume she knows how to do it. this is the default for "normal" users.

I'd ask the password directly on the node start (if this option is enabled). The rational is that a user doesn't want just a node, she wants it with the wallet.

The most confusing part with that is mining, the miner waits for wallet which is not obvious for the most of users, I see it daily in gitter

@yeastplume
Copy link
Member

I think this is okay now given the instruction docs we have. I'm still wary of running anything by default, the user should explicitly create a wallet with a password and run the listener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants