Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip_read improvement with cache #1928

Closed
garyyu opened this issue Nov 5, 2018 · 2 comments
Closed

zip_read improvement with cache #1928

garyyu opened this issue Nov 5, 2018 · 2 comments

Comments

@garyyu
Copy link
Contributor

garyyu commented Nov 5, 2018

Copy from #1923

@antiochp Idea for further enhancement - we probably only need to generate one of these and return the same state file to both peers if we get multiple requests like this.
It can probably be "cached" locally and reused, at least for some period of time.

will do this improvement once I get time.

@hashmap
Copy link
Contributor

hashmap commented Jun 14, 2019

Do we cache txhashet as part of #2813?

@antiochp
Copy link
Member

I believe we do yes. We were already "caching" them based on current header hash, just not able to take advantage of it within that 60s period.
#2813 will extend this period to 12 hours I believe.

@hashmap hashmap closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants