Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to "prev_root" in block headers #1726

Closed
6 tasks done
antiochp opened this issue Oct 11, 2018 · 3 comments
Closed
6 tasks done

Commit to "prev_root" in block headers #1726

antiochp opened this issue Oct 11, 2018 · 3 comments
Assignees
Labels
consensus breaking Use for issues or PRs that will break consensus and force a hard fork enhancement
Milestone

Comments

@antiochp
Copy link
Member

antiochp commented Oct 11, 2018

Related - #1555 (FlyClient).
This is definitely not a full flyclient impl but it moves us a step in that direction.

Starting this issue to track concrete steps toward committing to prev_root in our block headers.

Tasks -

  • subsequently on testnet4 (or later) hardfork to remove previous hash on headers

I think -
a) We can get this into testnet4 without too much hassle.
b) And that the benefits to doing so now are worth it.

@ignopeverell @yeastplume @tromp does this approach make sense?

@antiochp antiochp added enhancement consensus breaking Use for issues or PRs that will break consensus and force a hard fork labels Oct 11, 2018
@antiochp antiochp added this to the Testnet4 milestone Oct 11, 2018
@antiochp antiochp self-assigned this Oct 11, 2018
@tromp
Copy link
Contributor

tromp commented Oct 11, 2018

That makes perfect sense. Before removing prevhash, have as many sanity checks as possible that it's consistent with the header MMR.

@yeastplume
Copy link
Member

Yes, seems like a good approach, we can try it and work on removing previous hash if all goes well.

@antiochp
Copy link
Member Author

Closing this. We are up and running on pre-testnet4. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus breaking Use for issues or PRs that will break consensus and force a hard fork enhancement
Projects
None yet
Development

No branches or pull requests

4 participants
@tromp @yeastplume @antiochp and others