From 3a333ae00f9c1f521d91b972f594fbb7738757b0 Mon Sep 17 00:00:00 2001 From: Antioch Peverell Date: Thu, 5 Dec 2019 10:32:01 +0000 Subject: [PATCH] deadlock risk in check_orphans called from txhashset_write (#3156) --- chain/src/chain.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/chain/src/chain.rs b/chain/src/chain.rs index b468c67c0b..e08253dfa5 100644 --- a/chain/src/chain.rs +++ b/chain/src/chain.rs @@ -441,7 +441,7 @@ impl Chain { } /// Check for orphans, once a block is successfully added - pub fn check_orphans(&self, mut height: u64) { + fn check_orphans(&self, mut height: u64) { let initial_height = height; // Is there an orphan in our orphans that we can now process? @@ -999,9 +999,6 @@ impl Chain { debug!("txhashset_write: replaced our txhashset with the new one"); - // Check for any orphan blocks and process them based on the new chain state. - self.check_orphans(header.height + 1); - status.on_done(); Ok(false)