Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent Change-Color Portal #2

Open
mikyll opened this issue Apr 6, 2021 · 0 comments
Open

Permanent Change-Color Portal #2

mikyll opened this issue Apr 6, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@mikyll
Copy link
Owner

mikyll commented Apr 6, 2021 •
edited
Loading

File PermanentChangeMaterialOnTriggerSystem.cs

Currently the system uses the StatefulTriggerEvent buffer, even if it only check for the entity to enter, so we actually don't need the buffer state.
The purpose is to remove the usage of the buffer (in DynamicBufferTriggerEventAuthoring.cs), using just the simple TriggerEvent. This will solve the warning problem with memory leak in the newer version, which was thrown when we tried to use DynamicBufferTriggerEventAuthoring.cs.
@mikyll mikyll changed the title Fix PermanentChangeMaterialPortal System Permanent Change-Color Portal fix Apr 6, 2021
@mikyll mikyll changed the title Permanent Change-Color Portal fix Permanent Change-Color Portal Apr 6, 2021
@mikyll mikyll added the good first issue Good for newcomers label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikyll