feat(migrations): allow specifying list of migrations

[thomaschaaf]

No description provided.

[B4nan]

this fails in the CI as well as on my end, probably bad/outdated typings? the migrationsList is in the sources, but not in the d.ts

maybe we could access it from the umzug default export, or we would need to augment the typings (via declaration merging)

[thomaschaaf]

I tried everything I could but ultimately this seems to be the only way I am able to fix this until the typings are merged.

[B4nan]

maybe we could use your fork as a dependency?

or as i mentioned before, we could use declaration merging

[thomaschaaf]

I do not know how to do this. Would you mind showing how to do this?

[B4nan]

https://www.typescriptlang.org/docs/handbook/declaration-merging.html
https://stackoverflow.com/questions/37377731/extend-express-request-object-using-typescript

(the use case is pretty much the same as adding custom props to expess.req object)

[lgtm-com]

This pull request introduces 1 alert when merging b23ef06 into 0474787 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[lgtm-com]

This pull request introduces 1 alert when merging 16669d9 into 0474787 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[B4nan]

Ok, tests are green, let's merge this, will take a look at the typings later

[thomaschaaf]

I fixed it here: c380d99

[B4nan]

Hmm damn umzug and their mediocre typings...

node_modules/@mikro-orm/migrations/Migrator.d.ts:4:16 - error TS2665: Invalid module name in augmentation. Module 'umzug' resolves to an untyped module at '/usr/local/var/www/vision.gl/vision-api/node_modules/umzug/lib/index.js', which cannot be augmented.

4 declare module 'umzug' {
                 ~~~~~~~


Found 1 error.

What about that PR you made against definitely typed, is that merged already?

[merceyz]

If you move that declare module 'umzug' to it's own file it should work
The fix is to make @types/umzug a dependency of @mikro-orm/migrations