QueryBuilder breaks when where() comes before update()

[parisholley]

Describe the bug

error: update "user" set "foobar" = '1' where "e0"."foobar" is null and "e0"."id" in ('1') - missing FROM-clause entry for table "e0"

broken

await em
  .createQueryBuilder(User)
  .where({ foobar: null, id: { $in: userIds } })
  .update({ foobar: member.id })
  .execute();

works

await em
  .createQueryBuilder(User)
  .update({ foobar: member.id })
  .where({ foobar: null, id: { $in: userIds } })
  .execute();

Versions

    "@mikro-orm/cli": "^4.5.9",
    "@mikro-orm/core": "^4.5.9",
    "@mikro-orm/migrations": "^4.5.9",
    "@mikro-orm/nestjs": "^4.3.1",
    "@mikro-orm/postgresql": "^4.5.9",
    "@mikro-orm/reflection": "^4.5.9",

[B4nan]

This particular case is working fine in master/v5, no plans to backport as it was fixed by a side effect, so I don't even know where to look for. Issues with this approach are there only when auto-joining comes to play - you can use deep conditions in update/delete and it will generate query with subselect to allow joining - but to do that we need to know the query type before applying the conditions, as that is where auto-joining happens.

Will at least add a validation for that case, as it is easy to validate (calling update/delete on a QB instance that already has some joins).

edit: Actually not, when I use the very same query as you do, with IN clause for PK, it adds the aliases, I guess I will just forbid calling update() after where() for all cases. I did try to implemented lazy processing of the queries, but everything is so tightly coupled that I had to surrender...