Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bigint as acceptable type of
isPrimaryKey
.I was following https://mikro-orm.io/docs/using-bigint-pks recipe, but saw that
update
queries were missingwhere
clause when using bigint as PK.I've pinpointed issue to those lines that doesn't prepare correct
where
object for knex whenwhere
is of bigint type.mikro-orm/packages/knex/src/AbstractSqlDriver.ts
Lines 270 to 272 in c0c658e