fix(core): ignore rest parameter in entity.toJSON()

mikro-orm · Apr 7, 2019 · 147de7d · 147de7d
1 parent 8c9ee4d
commit 147de7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/metadata/MetadataDiscovery.ts b/lib/metadata/MetadataDiscovery.ts
@@ -82,7 +82,7 @@ export class MetadataDiscovery {
     const meta = MetadataStorage.getMetadata(entity.name);
     meta.prototype = entity.prototype;
     meta.path = path || meta.path;
-    meta.toJsonParams = Utils.getParamNames(entity.prototype.toJSON || '');
+    meta.toJsonParams = Utils.getParamNames(entity.prototype.toJSON || '').filter(p => p !== '...args');
     const cache = meta.path && this.cache.get(entity.name + extname(meta.path));
 
     if (cache) {

diff --git a/tests/EntityFactory.test.ts b/tests/EntityFactory.test.ts
@@ -28,6 +28,7 @@ describe('EntityFactory', () => {
     expect(metadata[BaseEntity.name].properties['foo'].type).toBe('string');
     expect(metadata[Author.name]).toBeInstanceOf(Object);
     expect(metadata[Author.name].path).toBe(__dirname + '/entities/Author.ts');
+    expect(metadata[Author.name].toJsonParams).toEqual(['strict', 'strip']);
     expect(metadata[Author.name].properties).toBeInstanceOf(Object);
     expect(metadata[Author.name].properties['books'].type).toBe(Book.name);
     expect(metadata[Author.name].properties['books'].reference).toBe(ReferenceType.ONE_TO_MANY);