[instagram] Add support for user's saved medias #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge() `HttpErrorPage' is returned in shared_data at least when not authenticated or when trying to fetch other users saved medias (i.e. `instagram.com/<user>/saved/'). Gracefully handle it by returning nothing.
(Please note that this need the user to be authenticated and they can only see their saved media (not other users ones).) Close #643.
|
JFTR, the failing tests seems completely unrelated to the two commits added and in other extractors (not in the |
|
Thank you very much! |
|
Thank you @mikf for quickly merging it and for gallery-dl! Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for user's saved medias. Please note that the user should be
authenticated and they can download only their saved medias (not other users
saved medias).
Close #643.