Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl doesn't work with hentai2read #38

Closed
knguyen0105 opened this issue Sep 15, 2017 · 3 comments
Closed

gallery-dl doesn't work with hentai2read #38

knguyen0105 opened this issue Sep 15, 2017 · 3 comments

Comments

@knguyen0105
Copy link

It seems gallery-dl no longer works with hentai2read. I'm getting AttributeError: 'NoneType' object has no attribute 'group' when trying to download from the site.

I

@mikf
Copy link
Owner

mikf commented Sep 15, 2017

I'm not able to reproduce your issue. Unittest URLs work just fine and a few random picks from their front page don't have any problems either. Could you please post the relevant URL so I can look into this?

Do you get this error for every gallery or just for this one in particular?

@knguyen0105
Copy link
Author

Here is the error I'm getting.

PS C:\Users\khanh> gallery-dl.exe https://hentai2read.com/mousou_kuubo_girl/
[hentai2read][error] An unexpected error occurred:
Traceback (most recent call last):
  File "c:\programdata\anaconda3\lib\site-packages\gallery_dl\job.py", line 44, in run
    for msg in self.extractor:
  File "c:\programdata\anaconda3\lib\site-packages\gallery_dl\extractor\hentaicdn.py", line 27, in items
    data = self.get_job_metadata(page, images)
  File "c:\programdata\anaconda3\lib\site-packages\gallery_dl\extractor\hentai2read.py", line 61, in get_job_metadata
    "series": match.group(1) or "",
AttributeError: 'NoneType' object has no attribute 'group'

The example gallery-dl "http://gelbooru.com/index.php?page=post&s=list&tags=bonocho" works ok. It also works fine with e-hentai.

@mikf
Copy link
Owner

mikf commented Sep 16, 2017

I made a small mistake when looking at the changes to hentai2read.py yesterday and didn't realize that the regex pattern in use had changed since the 0.9.1 release, sorry about that. This problem has already been fixed in e61a3a5.

You could update to the latest dev-snapshot with
pip install --upgrade https://github.com/mikf/gallery-dl/archive/master.zip
if that is an option for you. Otherwise you would have to wait for the next release, but that might take a while.

@mikf mikf closed this as completed Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants