Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped file filenames replaced with "?" in console if matched to sqlite archive entry #3377

Closed
biggestsonicfan opened this issue Dec 8, 2022 · 5 comments

Comments

@biggestsonicfan
Copy link

Not sure if this was intentional to reduce overhead, but I'd prefer an option to see the full filenames if they're matched and not "guess" at what in the gallery was matching and if it was correct or not. Someone with an incorrect archive setup would have no idea what they were missing. Using latest from git.

@kattjevfel
Copy link
Contributor

The thing is that the filename isn't stored in the database, usually it's just the post ID or similar, so it has to "guess", instead of looking it up (which would miss the point of using the database in the first place).

@biggestsonicfan
Copy link
Author

biggestsonicfan commented Dec 8, 2022

That's never stopped gallery-dl from displaying the currently configured formula for filenames before, regardless if it's the actually saved file name or not. Hiding all information rather than displaying what it can is not an ideal situation, especially when trying to diagnose issues. Issues like if a post id has two attachments with identical filenames in it and the archive isn't set up to numerically increment attachments.

I am currently using the database to split my gallery archives across multiple drives, so they have different file paths, but duplicate files won't be downloaded. Again, no, I am not saving enough information to re-generate the filename in the archives themselves, but it would be nice to see which information I have configured (dates, post ids, file names, titles, etc) display as they are skipped.

Seeing thousands of '?' as they are skipped when using a batch file with -i doesn't help me understand how far gallery-dl is progressing until it just suddenly reaches the next line in the batch file.

I can't imagine this change was made lightly, as it had been this way since as far as I can remember, but I can't find the discussion, pull request, issue, or commit for the change. I'd like to see the reasoning behind it.

@wlritchi
Copy link
Contributor

wlritchi commented Dec 8, 2022

I believe this is the same as #3362

@biggestsonicfan
Copy link
Author

I believe this is the same as #3362

Ah, yup, so it is known and marked as regression. Closing as dupe. 😅

@biggestsonicfan
Copy link
Author

Whoops, looks like I could only close as "completed" or "not planned" via the GitHub app. You can't just "close" an issue anymore? Huh...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants