[bbc] - Add Support for Gallery Pages #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2021 19:54
Expand RegEx Pattern for `BbcProgrammeExtractor` to support gallery pages, e.g. `https://www.bbc.co.uk/programmes/b006q2x0/galleries?page=5`
Fix Indentation of Test Case
Fix Indentation Again
|
Thanks for the contribution. I extended this a bit to automatically scan all pages, starting with the one given by the I've also found a way to download larger image versions than the default 976x549 ones, by the way (6c11105) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand RegEx Pattern for
BbcProgrammeExtractorto support gallery pages, e.g.https://www.bbc.co.uk/programmes/b006q2x0/galleries?page=5This is my first PR here, so hopefully all is ok. I am not 100% certain on the tests, so any issues, please do let me know.
Tested the code locally and the pages downloaded as expected.