Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port q2-phylogeny actions to q2-iqtree2 #2

Open
gregcaporaso opened this issue Oct 22, 2020 · 4 comments
Open

port q2-phylogeny actions to q2-iqtree2 #2

gregcaporaso opened this issue Oct 22, 2020 · 4 comments

Comments

@gregcaporaso
Copy link
Collaborator

I'm thinking a good start for this plugin would be to move iqtree action(s) from q2-phylogeny to q2-iqtree2, and deprecate those in q2-phylogeny. We can then target an initial release of this plugin with the 2020.11 release, and remove the deprecated iqtree functionality from q2-phylogeny in the 2021.2 release.

Does that strategy make sense?

@mikerobeson
Copy link
Owner

That makes sense to me. :-)

@mikerobeson
Copy link
Owner

mikerobeson commented Oct 23, 2020

The IQ-TREE 2 actions have been ported over to q2-iqtree2 along with associated tests, including the align-to-tree-mafft-iqtree pipeline.

Questions / Comments:
Can anyone help me set this up to be conda installable? (should we worry about this now?)
I'm not sure how to set up lint-build-test / code coverage, any pointers?

@mikerobeson
Copy link
Owner

Deprecation notice was applied to iqtree related actions in this PR.

@gregcaporaso
Copy link
Collaborator Author

Sounds good @mikerobeson! I'm meeting with the engineers on my team this week - we'll follow up with you about conda and the tests then (it might make sense to do this using new functionality that we're testing for the QIIME 2 Library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants