Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since updating to mikepenz/action-junit-report@v5 the action is very slow #1251

Closed
ext opened this issue Nov 28, 2024 · 7 comments · Fixed by #1253
Closed

Since updating to mikepenz/action-junit-report@v5 the action is very slow #1251

ext opened this issue Nov 28, 2024 · 7 comments · Fixed by #1253

Comments

@ext
Copy link

ext commented Nov 28, 2024

Often the step taking two hours or longer.

image

Link to job: https://github.com/Forsakringskassan/designsystem/actions/runs/12059916705/job/33629384261
Link to Renovate PR bumping the version: Forsakringskassan/designsystem#118

The step is defined as:

            - name: Publish test results
              if: github.event_name == 'push' && (success() || failure())
              uses: mikepenz/action-junit-report@v5
              with:
                  report_paths: "packages/*/test-results/jest-junit.xml"
                  include_passed: true
                  check_name: Jest

It could be an error in our configuration but in that case I'm not really sure what.

@mikepenz
Copy link
Owner

Thank you for the report.

By any chance do you have a more granular output to see which step in the action takes the additional time for you?

@ext
Copy link
Author

ext commented Nov 28, 2024

By any chance do you have a more granular output to see which step in the action takes the additional time for you?

Dont know if it helps but I reran the job with debug logging: https://github.com/Forsakringskassan/designsystem/actions/runs/12059916705/job/33640545370?pr=118

Is there anything else I can do to get additional output?

@mikepenz
Copy link
Owner

that helps. thank you.

@mikepenz
Copy link
Owner

mikepenz commented Nov 28, 2024

So the problem appears to be that for your test cases the detected file name is not actually a filename:

Thu, 28 Nov 2024 09:26:09 GMT
##[debug]Resolving path for props should generate id when unset
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]followSymbolicLinks 'false'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]followSymbolicLinks 'false'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]implicitDescendants 'true'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]matchDirectories 'true'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]omitBrokenSymbolicLinks 'true'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]excludeHiddenFiles 'false'
Thu, 28 Nov 2024 09:26:09 GMT
##[debug]Search path '/home/runner/work/designsystem/designsystem'

Resolving path for "props should generate id when unset"

@mikepenz
Copy link
Owner

additionally you have enabled include_passed: true which will enable annotatePassed - resulting in it also attempting to find paths for every single passed test you have.

Which then will spend quite some time in the resolvePath function here: https://github.com/mikepenz/action-junit-report/blob/main/src/testParser.ts#L465-L473

@mikepenz
Copy link
Owner

mikepenz commented Nov 28, 2024

@ext can you please re-run with SHA: 80a45f1187e86cb9176306e728bedf5c51164d8a
Limitting the globber to always ever consider the workspace directory as root.

@ext
Copy link
Author

ext commented Nov 28, 2024

@mikepenz Thank you, that was quick. It does indeed work now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants