Merge pull request #1 from mike623/feature/error-callback

mike623 · web-flow · commit 34feb8e79785 · 2017-05-12T20:02:33.000+08:00
add optional error callback
diff --git a/index.js b/index.js
@@ -111,7 +111,11 @@ export default function* codePushSaga(options = {}) {
     try {
       yield call(sync, options.syncOptions, options.codePushStatusDidChange, options.codePushDownloadDidProgress);
     } catch (e) {
-      console.log(e);
+      if(options.onSyncError && typeof options.onSyncError === 'function'){
+        options.onSyncError(e)
+      }else{
+        console.log(e);
+      }
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,11 @@ export default function* codePushSaga(options = {}) {`
`111`	`111`	`try {`
`112`	`112`	`yield call(sync, options.syncOptions, options.codePushStatusDidChange, options.codePushDownloadDidProgress);`
`113`	`113`	`} catch (e) {`
`114`		`- console.log(e);`
	`114`	`+ if(options.onSyncError && typeof options.onSyncError === 'function'){`
	`115`	`+ options.onSyncError(e)`
	`116`	`+ }else{`
	`117`	`+ console.log(e);`
	`118`	`+ }`
`115`	`119`	`}`
`116`	`120`	`}`
`117`	`121`	`}`