Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate call syntax changed in Ember 3.10 #767

Open
ChristianGreinke opened this issue Jun 18, 2019 · 0 comments
Open

Deprecate call syntax changed in Ember 3.10 #767

ChristianGreinke opened this issue Jun 18, 2019 · 0 comments

Comments

@ChristianGreinke
Copy link

ChristianGreinke commented Jun 18, 2019

Deprecate warnings like in materialze-badge.js will break app build starting with ember 3.10 or specifically @ember/application/deprecations v1.0.0 as it is not following the new syntax for options parameter.
see:
deprecate = function deprecate(message, test, options) {
assert(missingOptionsDeprecation, Boolean(options && (options.id || options.until)));
assert(missingOptionsIdDeprecation, Boolean(options!.id));
assert(missingOptionsUntilDeprecation, Boolean(options!.until));

  invoke('deprecate', message, test, options);

};

From my opinion we could just remove these files anyway.

@jacobq jacobq changed the title Depreciate call syntax changed in Ember 3.10 Deprecate call syntax changed in Ember 3.10 Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant