Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress the pictures to load the page faster. #1

Closed
maciej-jasiewicz opened this issue Oct 20, 2022 · 10 comments
Closed

Compress the pictures to load the page faster. #1

maciej-jasiewicz opened this issue Oct 20, 2022 · 10 comments
Assignees

Comments

@maciej-jasiewicz
Copy link
Contributor

My idea of what can be improved is to compress the pictures to load the page faster for users with slow internet connection.

Greetings

@mikaelmonteirodev
Copy link
Owner

Hi @0x0undefined ! Great comment. Thank you for your collaboration. So, do you have any site suggestions for compressing the images?

> compress the pictures to load the page faster for users with slow internet connection.

@maciej-jasiewicz
Copy link
Contributor Author

My suggestion is to use: https://github.com/apps/imgbot

Best regards

@mikaelmonteirodev mikaelmonteirodev linked a pull request Oct 27, 2022 that will close this issue
@mikaelmonteirodev
Copy link
Owner

OK. I installed "Imgbot" on my github, but it didn't start compressing the images automatically as it says in the instructions. So I compressed the images in another way. I hope it got better.

Link to PR: #2 (comment)

@mikaelmonteirodev
Copy link
Owner

Hello 0x0undefined. I come again to thank you for the suggestion of imgbot. It ran on all my repositories. Thanks!

In this repo he created this PR #3

@mikaelmonteirodev mikaelmonteirodev removed the good first issue Good for newcomers label Oct 29, 2022
@maciej-jasiewicz
Copy link
Contributor Author

My suggestion is to change the image format to ".webp", which is more optimized and lightweight

Best regards

@maciej-jasiewicz
Copy link
Contributor Author

@mikaelmonteirodev please respond :)

@mikaelmonteirodev
Copy link
Owner

Hello @0x0undefined I'm sorry. I was waiting for guidance from my teacher. But if you can direct me to the best way to make this change I would be grateful.

@maciej-jasiewicz
Copy link
Contributor Author

Hello @0x0undefined I'm sorry. I was waiting for guidance from my teacher. But if you can direct me to the best way to make this change I would be grateful.

I created pull request #4 so you can merge my changes.

Have a nice day 👍

@mikaelmonteirodev
Copy link
Owner

mikaelmonteirodev commented Nov 8, 2022

Great! Thank you very much for your time. I wanted to know your opinion on a situation:

I saw in the imgbot repository on Github that they still don't have support for compressing the webp format. So, do you think it's better to keep this change to the webp you kindly made or wait for an update from imgbot that can compress this format?

Thank you once again! 👍

@mikaelmonteirodev
Copy link
Owner

I believe the issue problem is solved, right? So, what do you think about us discussing the webp improvement in PR #4?

Thank you again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants