Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] Why the database does not have unique constraints? #647

Open
6 tasks done
Cologler opened this issue Apr 10, 2024 · 2 comments · May be fixed by #1195
Open
6 tasks done

[Question] Why the database does not have unique constraints? #647

Cologler opened this issue Apr 10, 2024 · 2 comments · May be fixed by #1195
Labels
Bug Something isn't working
Milestone
v0.18.0

Comments

@Cologler
Copy link
Contributor

Cologler commented Apr 10, 2024 •
edited
Loading

Steps to reproduce

I have no idea where they come from. It might be because I'm refreshing the database while simultaneously importing data.

Expected behavior

The database is guarded by unique constraints.

Actual behavior

A lot of duplicated chapters:

image

Crash logs

No response

Mihon version

latest

Android version

12

Device

phone

Other details

Why the database does not have unique constraints like:

  • (manga_id, url) on chapters table
  • (source, url) on mangas table
  • (sort) on categories table
  • And more

Some related issues:

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.5.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Cologler Cologler added the Bug Something isn't working label Apr 10, 2024
@Cologler
Copy link
Contributor Author

When two elements have the same key, if we query one from the database, it would be the first one; if we query all from the database and then map by associateBy(), it would be the last one.

This inconsistency leads to numerous issues.

@Cologler
Copy link
Contributor Author

Even though the chapter_id of history has unique constraints, if the (manga_id, url) of chapter lacks unique constraints, then this is not unique:

https://github.com/mihonapp/mihon/blob/c94d212ef471012990bfe02ba43044de476ab9cd/app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/MangaRestorer.kt#L323C13-L323C106

This issue can lead to restoration failure with:

// <-- this is in my tachiyomi_restore.txt
ResultSet returned more than 1 row for history.sq:getHistoryByChapterUrl

By the way, since this is a relative URL, it might be duplicated across different sources. TachiyomiSY has already tried to fix this issue by use mangaId:

@Cologler Cologler mentioned this issue Apr 15, 2024
Closed
@AntsyLich AntsyLich mentioned this issue Aug 14, 2024
Closed
7 tasks
This was referenced Aug 25, 2024
Closed
Closed
Closed
@AntsyLich AntsyLich added this to the v0.17.0 milestone Aug 25, 2024
@AntsyLich AntsyLich mentioned this issue Aug 31, 2024
Closed
@AntsyLich AntsyLich modified the milestones: v0.17.0, v0.18.0 Oct 26, 2024
@AntsyLich AntsyLich linked a pull request Dec 2, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
v0.18.0
2 participants
@Cologler @AntsyLich