Skip to content

Commit cfcd40c

Browse files
authored
[aclorch] Fixed issue sonic-net#2204.Support IN_PORTS qualifer in MIRRORV6 table. (sonic-net#2668)
What I did Fixed issue sonic-net#2204 Why I did it Community test case "sonic-mgmt/tests/everflow/everflow/test_everflow_per_interface.py::test_everflow_per_interface[ipv6]" fails for IPV6 traffic with below error. Feb 15 09:06:44.205490 sonic ERR swss#orchagent: :- validateAclRuleMatch: Match SAI_ACL_ENTRY_ATTR_FIELD_IN_PORTS in rule RULE_1 is not supported by table EVERFLOWV6 Feb 15 09:06:44.206501 sonic ERR swss#orchagent: :- doAclRuleTask: Unknown or invalid rule attribute 'IN_PORTS : Ethernet2,Ethernet3,Ethernet8,Ethernet9' Feb 15 09:06:44.207624 sonic ERR swss#orchagent: :- doAclRuleTask: Failed to create ACL rule. Rule configuration is invalid How I verified it Verify the Community Testcase with IPV6 traffic is passing. Signed-off-by: rajkumar38 <[email protected]>
1 parent 35a7ab0 commit cfcd40c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

orchagent/aclorch.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -3216,7 +3216,7 @@ void AclOrch::initDefaultTableTypes()
32163216
* | -----------------------------------------------------------------|
32173217
* | MATCH_ETHERTYPE | √ | √ | |
32183218
* |------------------------------------------------------------------|
3219-
* | MATCH_IN_PORTS | √ | √ | |
3219+
* | MATCH_IN_PORTS | √ | √ | |
32203220
* |------------------------------------------------------------------|
32213221
*/
32223222

@@ -3277,6 +3277,7 @@ void AclOrch::initDefaultTableTypes()
32773277
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_L4_SRC_PORT))
32783278
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_L4_DST_PORT))
32793279
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_TCP_FLAGS))
3280+
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_IN_PORTS))
32803281
.withMatch(make_shared<AclTableMatch>(SAI_ACL_TABLE_ATTR_FIELD_DSCP))
32813282
.withMatch(make_shared<AclTableRangeMatch>(set<sai_acl_range_type_t>{
32823283
{SAI_ACL_RANGE_TYPE_L4_SRC_PORT_RANGE, SAI_ACL_RANGE_TYPE_L4_DST_PORT_RANGE}}))

tests/test_mirror_ipv6_separate.py

+1
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ def test_MirrorV6TableCreation(self, dvs, testlog):
237237
"SAI_ACL_TABLE_ATTR_FIELD_L4_DST_PORT",
238238
"SAI_ACL_TABLE_ATTR_FIELD_TCP_FLAGS",
239239
"SAI_ACL_TABLE_ATTR_FIELD_DSCP",
240+
"SAI_ACL_TABLE_ATTR_FIELD_IN_PORTS",
240241
"SAI_ACL_TABLE_ATTR_FIELD_OUTER_VLAN_ID"
241242
]
242243

0 commit comments

Comments
 (0)