Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redux Icons and Folders #190

Closed
keidsondesigner opened this issue Mar 17, 2024 · 8 comments
Closed

Add Redux Icons and Folders #190

keidsondesigner opened this issue Mar 17, 2024 · 8 comments
Assignees
Labels
icon request Request for a new icon
Milestone

Comments

@keidsondesigner
Copy link

It would be great to have a specific icon for Redux files and folders

  • I've created some examples of the standard icons and folders

Screenshot 2024-03-17 130341

@miguelsolorio
Copy link
Owner

@keidsondesigner Thank you for using the template file! Can you share your Figma file so I can add them to the main one?

@miguelsolorio miguelsolorio added the icon request Request for a new icon label Mar 18, 2024
@keidsondesigner
Copy link
Author

yep! what's your email?

@miguelsolorio
Copy link
Owner

You can just share a link that's visible to the public and I'll copy/paste them over

@miguelsolorio
Copy link
Owner

Can you share what file names/patterns these map to?

@miguelsolorio
Copy link
Owner

@keidsondesigner I've been looking at other file icon themes and I can't find examples of file names that these would map to, do you mind providing some examples? I don't use redux/react so I wouldn't know.

@keidsondesigner
Copy link
Author

Hi @miguelsolorio it looks like this
Screenshot 2024-03-23 225947
Screenshot 2024-03-23 230202

@miguelsolorio miguelsolorio self-assigned this Mar 27, 2024
@miguelsolorio miguelsolorio added this to the 0.0.17 milestone Mar 27, 2024
@miguelsolorio
Copy link
Owner

I've added these redux files:

CleanShot 2024-03-27 at 11 21 08@2x

I also added the related folder icons as well but did not assign them in the theme because the names are a little too generic to conflict with other folders names (actions, selector, etc.). I also noticed other file themes do a similar thing. Feel free to define them in your user settings if you'd like to use them:

  "symbols.folders.associations": {
    "actions": "folder-redux-actions",
    "facade": "folder-redux-facade",
    "reducer": "folder-redux-reducer",
    "selector": "folder-redux-selector",
    "effects": "folder-redux-effects"
  }

CleanShot 2024-03-27 at 11 31 09@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

No branches or pull requests

2 participants