Allow configuring underlying aiohttp websocket #293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-y
force-pushed
the
by/websocket-options
branch
from
67e8b58 to
08c4428
Compare
bruce-y
force-pushed
the
by/websocket-options
branch
from
08c4428 to
c53668b
Compare
|
While this, in principle, is okay, I do not like the idea of introducing features that are partially implemented. In this case, you have implemented the async client, but there's nothing to support the sync client and the sync and async servers. |
|
I've just added implementation for the sync client as well. I'm not sure what you're envisioning for exposing similar options for the server/async server. |
|
Merged with some minor changes and added tests. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR naively attempts to address miguelgrinberg/python-socketio#486. I am currently running into the same issue and need to be able to configure the
max_msg_sizewhen callingws_connect.