-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added timeout to create_websocket() #286
Conversation
Would it be possible to implement the same change on the async client? And adding a test that ensures that the request timeout is used when it is not set to the default? Thanks! |
Yeah, will do! Will update the PR when it is done. |
I believe this is it for the asyncio as well. Thanks! |
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 1934 1934
Branches 377 377
=========================================
Hits 1934 1934
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sorry for the many commits, I am new to contributing and wasn't aware of all the checks. Hopefully everything is ok now. Thanks again! |
Thanks! |
Currently the create_websocket() call doesn't have any timeout which means it can wait forever for the websocket to connect.
I made it use the same
request_timeout
as the one used for pooling connection.This is a pretty small patch, hope it won't be a problem to merge.