Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-integer ping interval and timeout #201

Merged

Conversation

akash-roboticist
Copy link
Contributor

Some socket.io servers (non python) serve ping_timeout and ping_interval as strings rather than integers, this is causing the client to break at startup.

for reference, here's a response from a server I am connecting to -

INFO:engineio.client:WebSocket connection accepted with {'sid': 'some_long_sid', 'upgrades': [], 'pingInterval': '15000', 'pingTimeout': '10000'}

Some socket.io servers (non python) serve `ping_timeout` and `ping_interval` as strings rather than integers, this is causing the client to break at startup.
@miguelgrinberg
Copy link
Owner

Looks good. Thanks!

@miguelgrinberg miguelgrinberg merged commit c169991 into miguelgrinberg:master Nov 10, 2020
@akash-roboticist
Copy link
Contributor Author

@miguelgrinberg thanks for merging.
Since this would unblock my current project, would it be possible to spin out the next release with this fix soon? I'd like to keep using a released version rather than locally modified versions.

Appreciate your work!

@miguelgrinberg
Copy link
Owner

I have two more outstanding bugs that I'd like to address before the next release. In the meantime you can install the master branch direct from git, there is no need to apply local modifications.

@akash-roboticist
Copy link
Contributor Author

Oh yes I forgot about that, let me do that; thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants