Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section Gap on IOS 11 #246

Open
wickedw opened this issue Sep 22, 2017 · 0 comments
Open

Section Gap on IOS 11 #246

wickedw opened this issue Sep 22, 2017 · 0 comments

Comments

@wickedw
Copy link

wickedw commented Sep 22, 2017

Hi,

If you use MTD (I am using the latest IOS 11 tooling) you get a N pixel blank gap at the end of each section (it looked like it could be the header initially) when using Plain table style.

I had a legacy app that suddenly just went wonky when upgrading to IOS 11.

The confusing bit was that the sample does not exhibit this as I found out you need to update the app icon and launch images to use an asset catalog so it uses full screen / @3x mode, then you can see the padding everywhere.

After tracing through the code, I noticed this was the culprit -

public override nfloat GetHeightForHeader (UITableView tableView, nint sectionIdx)
		{
			var section = Root.Sections [(int) sectionIdx];
			if (section.HeaderView == null)
				return -1;
			return section.HeaderView.Frame.Height;
		}

if you return -1 then the gap happens, 0 removes it, I am just in the middle of downloading the IOS 8 emulators to see how to complete the code (see if we need any version branching on the - 1 / 0).

Do you want me to update the sample and submit a pull request when I think I have a fix?

Example -

ss2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant