Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageLoader #189

Open
nberardi opened this issue Sep 13, 2013 · 0 comments
Open

ImageLoader #189

nberardi opened this issue Sep 13, 2013 · 0 comments

Comments

@nberardi
Copy link

I have been looking over the internals of ImageLoader and curious what this code is suppose to do.

https://github.com/migueldeicaza/MonoTouch.Dialog/blob/master/MonoTouch.Dialog/Utilities/ImageLoader.cs#L317

if (uri == null){
    Console.Error.WriteLine ("Dropping request {0} because url is null", uri);
    pendingRequests.Remove (uri);
    uri = null;
}

The value of uri is already checked for null, so it can't be written to the console or removed from the pendingRequest.

This looks like just unneeded artifact code that is left over from a previous incarnation. Would you be willing to take a pull request to clean up this code and other things I have noticed in ImageLoader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant