-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TypeScript imports resolver #1505
Comments
Thank you. This seems to introduce a good amount of details. Would you be interested in contributing it? |
Sure! Just wanted to be sure that it's something you are interested in |
@mightyiam I have created #1509 let me know what you think |
Seems like the original PR was rejected. In my case, I'm not looking for a code mod feature, but somehow VSCode doesn't really provide great visibility for unused imports e.g. As you can see, lower opacity is something not ideal. However, if I however over the the problem, I can see it clearly. TS Language Server also doesn't seem to populate the Problems tab and my TypeScript compilier doesn't even complain about it! So my project will probably be filled with unused code that requires code modding. Not what I expected if we are able to do a lint checker. I also expected TS to not give out false positives... Anyway for alternatives, I suggest: |
@psychobolt doesn't that seem like an IDE issue to you? Does |
Seems like you have to explicitly tell TypeScript to warn about unused variables e.g "noUnusedLocals": true If I turn on this compilerOption, tsc will complain. Anyways there is already a rule Some more info on how the IDE works: microsoft/vscode#219335 |
Hi! Are there any plans to use TypeScript imports resolver in
eslint-plugin-import
? It seems a bit off that this package is designed for TypeScript but doesn't include this by default.P.S. Thank you for all your hard work over the years! Your efforts deserve more recognition!
The text was updated successfully, but these errors were encountered: