Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixing fails when a proxy has removed the file extension. #13

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

AndrewKvalheim
Copy link
Contributor

This change permits arbitrary proxy paths by relying on content type rather than file extension.

@porada
Copy link
Contributor

porada commented Oct 14, 2014

Thanks for the pull request.

@tdreyno, could you take a look and merge if this is okay with you?

@tdreyno
Copy link
Member

tdreyno commented Oct 14, 2014

@porada We're discussing this same thing in core and will let you know how it resolves.

@porada
Copy link
Contributor

porada commented Oct 14, 2014

👍

@porada
Copy link
Contributor

porada commented Jan 29, 2015

@tdreyno, what’s the status?

@tdreyno
Copy link
Member

tdreyno commented Jan 30, 2015

I think this makes sense here, but not in core.

tdreyno added a commit that referenced this pull request Jan 30, 2015
Prefixing fails when a proxy has removed the file extension.
@tdreyno tdreyno merged commit 0259f48 into middleman:master Jan 30, 2015
@porada
Copy link
Contributor

porada commented Jan 30, 2015

Great. Released in v2.4.2.

@AndrewKvalheim, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants