Skip to content

Rename RedirectHandlerOptions variables to match purpose #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikithauc merged 1 commit into from
Sep 20, 2021
Merged

Rename RedirectHandlerOptions variables to match purpose #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/middleware/options/RedirectHandlerOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class RedirectHandlerOptions implements MiddlewareOptions {
* @private
* A member holding default shouldRedirect callback
*/
private static defaultShouldRetry: ShouldRedirect = () => true;
private static defaultShouldRedirect: ShouldRedirect = () => true;

/**
* @public
Expand All @@ -63,7 +63,7 @@ export class RedirectHandlerOptions implements MiddlewareOptions {
* @param {ShouldRedirect} [shouldRedirect = RedirectHandlerOptions.DEFAULT_SHOULD_RETRY] - The should redirect callback
* @returns An instance of RedirectHandlerOptions
*/
public constructor(maxRedirects: number = RedirectHandlerOptions.DEFAULT_MAX_REDIRECTS, shouldRedirect: ShouldRedirect = RedirectHandlerOptions.defaultShouldRetry) {
public constructor(maxRedirects: number = RedirectHandlerOptions.DEFAULT_MAX_REDIRECTS, shouldRedirect: ShouldRedirect = RedirectHandlerOptions.defaultShouldRedirect) {
if (maxRedirects > RedirectHandlerOptions.MAX_MAX_REDIRECTS) {
const error = new Error(`MaxRedirects should not be more than ${RedirectHandlerOptions.MAX_MAX_REDIRECTS}`);
error.name = "MaxLimitExceeded";
Expand Down
2 changes: 1 addition & 1 deletion test/common/middleware/RedirectHandlerOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ describe("RedirectHandlerOptions.ts", () => {
it("Should initialize instance with default options", () => {
const options = new RedirectHandlerOptions();
assert.equal(options.maxRedirects, RedirectHandlerOptions["DEFAULT_MAX_REDIRECTS"]);
assert.equal(options.shouldRedirect, RedirectHandlerOptions["defaultShouldRetry"]);
assert.equal(options.shouldRedirect, RedirectHandlerOptions["defaultShouldRedirect"]);
});
});
});