feature/lean batches #129
Merged
feature/lean batches #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces older, native client dependent implementation by a new implementation for batches
- fixes a bug where the batch request method would not be cased properly
baywet
requested review from
MIchaelMainer,
ddyett,
nikithauc and
zengin
as code owners
This was referenced Feb 2, 2021
This comment has been minimized.
This comment has been minimized.
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
zengin
approved these changes
Feb 5, 2021
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
LGTM. I have a few nitpicks.
src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/content/BatchRequestContentTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mustafa Zengin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Feedback about how batch requests might work #117