Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to specify MPN IDs when creating app registrations #206

Open
SheaSmith opened this issue Dec 18, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request graph-platform triaged Team has triaged the item

Comments

@SheaSmith
Copy link

Is your feature request related to a problem? Please describe.
We're currently reviewing the manual steps required for creating app registrations. We've managed to remove the vast majority of manual steps, however two prominent steps remain - setting a logo (covered by #153) and setting our MPN ID on the registration. Currently we get the following error when attempting to do this:

{
  "code": "DeploymentFailed",
  "target": "/subscriptions/<id>/resourceGroups/DS-Infrastructure/providers/Microsoft.Resources/deployments/test",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.",
  "details": [
    {
      "code": "Forbidden",
      "message": "verifiedPublisher properties cannot be set during Application creation. Graph client request id: 802f3c5e-18df-46aa-85b9-cb522bf1c7a9. Graph request timestamp: 2024-12-18T03:38:24Z."
    }
  ]
}

with the following Bicep file:

extension microsoftGraphV1_0

resource appReg 'Microsoft.Graph/[email protected]' = {
  uniqueName: 'test-registration'
  displayName: 'Test Reg'
  verifiedPublisher: {
    verifiedPublisherId: '<id>'
  }
}

Describe the solution you'd like
It would be great to be able to specify the MPN ID on our registrations in the Bicep script.

@SheaSmith SheaSmith added the enhancement New feature or request label Dec 18, 2024
@dkershaw10 dkershaw10 self-assigned this Dec 18, 2024
@dkershaw10
Copy link
Collaborator

@SheaSmith thanks for filing this issue. Setting the verified publisher is accomplished through a separate API from /applications - https://learn.microsoft.com/graph/api/application-setverifiedpublisher?view=graph-rest-1.0&tabs=http. This is something we were not aware of on the Graph Bicep team.

Not sure why this was separated out into a service action on a different endpoint, but it definitely represents a problem for us to expose the functionality in a declarative and idempotent fashion.

We'll need to sync with the App Platform team (who own these Graph APIs) to understand what the options are here.

@dkershaw10
Copy link
Collaborator

@SheaSmith UPDATE: we are looking into options to fix this, so that this property can be set. In the meantime, we have updated the verifiedPublisher property to be read-only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graph-platform triaged Team has triaged the item
Projects
None yet
Development

No branches or pull requests

3 participants