Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): add stackblitz button styling for high contrast theming #3213

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jun 12, 2024

Closes #3078

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner June 12, 2024 13:44
@Mnickii Mnickii changed the title fix(a11y): add forced colors to fix theming in high contrast in storybook editor fix(a11y): add stackblitz button styling for high contrast theming Jun 12, 2024
Copy link

📖 The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 12, 2024

Hi @Raisul123 , @vagpt , this is ready for review.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jun 12, 2024
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Jun 13, 2024
@vagpt
Copy link
Collaborator

vagpt commented Jun 13, 2024

This issue is working fine on the URL below, hence we are good to close the bug related to this PR.

URL:

https://mgt.dev/next/pr/3213/?path=/story/editor--editor

Snippet:

image

Copy link

📖 The updated storybook is available here

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Mnickii Mnickii merged commit cb7621a into main Jun 13, 2024
11 checks passed
@Mnickii Mnickii deleted the fix/bug-3078 branch June 13, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants