Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aspnet proxy provider sample #2594

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2464

PR Type

  • Bugfix

Description of the changes

apply dark theme to header
fix header button alignment
make Messages page force authentication
fix team chanel selection event handler

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

apply dark theme to header
fix header button alignment
make Messages page force authentication
fix team chanel selection event handler
@gavinbarron gavinbarron requested a review from a team as a code owner July 7, 2023 20:05
@ghost
Copy link

ghost commented Jul 7, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@gavinbarron gavinbarron enabled auto-merge (squash) July 11, 2023 18:27
@gavinbarron gavinbarron merged commit 362339a into main Jul 11, 2023
@gavinbarron gavinbarron deleted the fix/aspnet-proxy-provider-sample branch July 11, 2023 18:35
gavinbarron added a commit that referenced this pull request Aug 21, 2023
apply dark theme to header
fix header button alignment
make Messages page force authentication
fix team chanel selection event handler

Co-authored-by: Nickii Miaro <[email protected]>
gavinbarron added a commit that referenced this pull request Aug 21, 2023
apply dark theme to header
fix header button alignment
make Messages page force authentication
fix team chanel selection event handler

Co-authored-by: Nickii Miaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[SAMPLE] Review proxy-provider-asp-net-core for v3.0
2 participants