Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMPLE] Review electron-app for v3.0 #2462

Closed
Tracked by #2011
sebastienlevert opened this issue Jun 15, 2023 · 3 comments · Fixed by #2482
Closed
Tracked by #2011

[SAMPLE] Review electron-app for v3.0 #2462

sebastienlevert opened this issue Jun 15, 2023 · 3 comments · Fixed by #2482
Assignees
Milestone

Comments

@sebastienlevert
Copy link
Contributor

Review for v3.0 of the sample https://github.com/microsoftgraph/microsoft-graph-toolkit/tree/main/samples/electron-app

@ghost
Copy link

ghost commented Jun 15, 2023

Hello sebastienlevert, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@sebastienlevert sebastienlevert added this to the v3.0.0 milestone Jun 15, 2023
@sebastienlevert sebastienlevert moved this from Needs Triage 🔍 to Todo 📃 in Graph Toolkit Jun 15, 2023
@sebastienlevert sebastienlevert mentioned this issue Jun 15, 2023
63 tasks
@gavinbarron gavinbarron self-assigned this Jun 16, 2023
@gavinbarron gavinbarron moved this from Todo 📃 to In Progress 🚧 in Graph Toolkit Jun 16, 2023
@gavinbarron
Copy link
Member

gavinbarron commented Jun 16, 2023

Oh boy we have some issues here:

mgt-person elements have a problem with their images:

Image

Suspect that setting the width on the avatar-wrapper class will resolve this across the board

calls to beta endpoints are failing

Calls to beta fail with HTTP 401 and an error:

{
  "error": {
    "code": "InvalidAuthenticationToken",
    "message": "CompactToken parsing failed with error code: 80049217",
    "innerError": {
      "date": "2023-06-16T22:30:57",
      "request-id": "5572066f-d08b-49c0-8116-fc534b1c4f1d",
      "client-request-id": "360cd8f6-1c4f-0bff-5c96-e3fe400ffa98"
    }
  }
}

Quick inspection of the network calls shows that the bearer token is not being correctly set for the request and has a value of undefined in the request sent over the wire

Resolution: missing scope in provider and no incremental consent. Add the scope team.readbasic.all in main.ts

teams channel picker shows no channels when activated.

Network shows that the joinedTeams request is made and returned a valid response.

Fixed by adding the scope noted above;

@ghost ghost added the State: In Review label Jun 16, 2023
@gavinbarron gavinbarron linked a pull request Jun 16, 2023 that will close this issue
6 tasks
@gavinbarron gavinbarron moved this from In Progress 🚧 to In Review 💭 in Graph Toolkit Jun 16, 2023
@sebastienlevert
Copy link
Contributor Author

This looks good 🤣 Good catch!

@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Graph Toolkit Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants